Proper dependencies for FCS Pi0 used in QA #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genevb
requested review from
plexoos,
klendathu2k,
fisyak,
R-Witt and
iraklic
as code owners
klendathu2k
reviewed
Mar 20, 2024
| @@ -1639,6 +1639,7 @@ Bfc_st BFC[] = { // standard chains | |||
| "StFcsClusterMaker","StFcsClusterMaker","Fill FCS clusters", kFALSE}, | |||
| {"fcsPoint" ,"","fcsChain", "StEvent,fcsDb", | |||
| "StFcsPointMaker","StFcsPointMaker,libMinuit","Fill FCS points", kFALSE}, | |||
| {"fcsPi0Libs","", "", "MuDst", "", "StFcsPi0FinderForEcal", "Libs for FCS Pi0 Finder", kFALSE}, | |||
There was a problem hiding this comment.
FCS pi0 finder uses the MuDst for input rather than StEvent.
There was a problem hiding this comment.
It seems an odd mix of MuDst and StEvent: it appears to require StEvent for its Make() member function, but then may call some MuDst static functions later in that member function. It's likely that these dependencies can be further reduced/improved, but for now I'm trying to ensure St_QA_Maker's dependencies, as that's my responsibility.
plexoos
approved these changes
Mar 24, 2024
akioogawa
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue brought in PR #437 :
St_QA_Maker should not directly depend on MuDst (a solution proposed in #437 ), but instead should depend on the StFcsPi0FinderForEcal, which itself has a dependency on MuDst.